D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  In https://phabricator.kde.org/D6067#114528, @apol wrote:
  
  > In https://phabricator.kde.org/D6067#114498, @leinir wrote:
  >
  > > On a similar note to handling comments, how does it now handle unknown/garbage tags? While it won't affect the cache code, it would potentially affect other things (ocs is not guaranteed to be perfectly formed, and it's one of the ways the framework's retained backwards compatibility). From what i can tell, this would assert when an unknown tag is encountered, right?
  >
  >
  > This is for .knsregistry files, not OCS. These files are generated by the very same class here.
  
  
  You are quite right, i forgot the attica content's not parsed using knscore's functions, just the staticxml provider... because i'm a silly person :) Obviously just fine, then, go for it!

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6067

To: apol, #frameworks, leinir
Cc: leinir, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170606/7b017d76/attachment.html>