Review Request 130138: Set QT_NO_EXCEPTIONS when building *.mm files

Harald Fernengel harry at kdevelop.org
Thu Jun 1 13:27:27 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130138/
-----------------------------------------------------------

(Updated June 1, 2017, 1:27 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: sonnet


Description
-------

Apparently, exceptions are disabled when building *.mm files.
The alternative would be to set

target_compile_options(sonnet_nsspellchecker PRIVATE "-fexceptions")

in order to force exception to be on for *.mm files. However, since
exceptions aren't used in the code, let's just build without.


Diffs
-----

  src/plugins/nsspellchecker/CMakeLists.txt f8c99d1ea080b1e28f60c57f8f588ed059c96711 

Diff: https://git.reviewboard.kde.org/r/130138/diff/


Testing
-------


Thanks,

Harald Fernengel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170601/5c626240/attachment.html>


More information about the Kde-frameworks-devel mailing list