D6906: Create a "." entry even on empty dirs

[David Faure]

dfaure added a comment.


  This commit breaks plasmashell startup for me, with a non-empty desktop:/
  
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister KCoreDirListerCache::slotEntries: KCoreDirListerCache(0x7f6a2002c980) KIO::ListJob(0x26a9ae0) new entries for  QUrl("desktop:/")
  2017-07-28T10:51:54 plasmashell(5605)/default KCoreDirListerCache::slotEntries: ".directory"
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister KCoreDirListerCache::slotEntries: Adding item:  QUrl("desktop:/.directory")
  2017-07-28T10:51:54 plasmashell(5605)/default KCoreDirListerCache::slotEntries: ".."
  2017-07-28T10:51:54 plasmashell(5605)/default KCoreDirListerCache::slotEntries: "."
  2017-07-28T10:51:54 plasmashell(5605)/default KCoreDirListerCache::slotEntries: "Home.desktop"
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister KCoreDirListerCache::slotEntries: Adding item:  QUrl("desktop:/Home.desktop")
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister KCoreDirLister::Private::addNewItem: in QUrl("desktop:/") item: QUrl("desktop:/Home.desktop")
  2017-07-28T10:51:54 plasmashell(5605)/default KCoreDirListerCache::slotEntries: "trash.desktop"
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister KCoreDirListerCache::slotEntries: Adding item:  QUrl("desktop:/trash.desktop")
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister KCoreDirLister::Private::addNewItem: in QUrl("desktop:/") item: QUrl("desktop:/trash.desktop")
  2017-07-28T10:51:54 plasmashell(5605)/default KCoreDirListerCache::slotEntries: done
  2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister KCoreDirListerCache::slotEntries: KCoreDirListerCache(0x7f6a2002c980) KIO::ListJob(0x26a9ae0) new entries for  QUrl("desktop:/")
  2017-07-28T10:51:54 plasmashell(5605)/default unknown: ASSERT: "dir->rootItem.isNull()" in file /d/kde/src/5/frameworks/kio/src/core/kcoredirlister.cpp, line 1202
  
  At first sight it looks like "." is emitted multiple times.
  
  Please revert and fix it better ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6906

To: albertvaka, #frameworks, elvisangelaccio
Cc: dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170728/c63c5d9c/attachment.html>