D6829: Add ability to use the new kauth helper in file ioslave

David Faure noreply at phabricator.kde.org
Thu Jul 27 07:56:13 UTC 2017


dfaure added inline comments.

INLINE COMMENTS

> slavebase.cpp:1464
> +    QByteArray buffer;
> +    buffer.setNum(0);
> +    send(MSG_PRIVILEGE_EXEC);

Better in one line: const QByteArray buffer = "0";

> file.h:115
> +    };
> +    virtual bool execWithElevatedPrivilege(int error, ActionType action, const QVariant &arg1,
> +                                           const QVariant &arg2 = QVariant(),

Why virtual? Nothing inherits from this class, right?

REVISION DETAIL
  https://phabricator.kde.org/D6829

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170727/47345f47/attachment.html>


More information about the Kde-frameworks-devel mailing list