D6833: Add support for PrivilegeExecution in KIO jobs

Chinmoy Ranjan Pradhan noreply at phabricator.kde.org
Wed Jul 26 11:12:25 UTC 2017


chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:1674
> Should the flag always be set here? Or only if m_privilegeExecutionEnabled is true?

Ideally it should be set when m_privilegeExecutionEnabled is true. But it will add more lines. Even though its just 2-3 lines, it doesn't look good. 
Besides the flag is ineffective if the parent job doesn't have this flag set. Shall I remove it?

REVISION DETAIL
  https://phabricator.kde.org/D6833

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170726/0cbce664/attachment.html>


More information about the Kde-frameworks-devel mailing list