D6856: Reset url in closeUrl()

Elvis Angelaccio noreply at phabricator.kde.org
Mon Jul 24 21:45:52 UTC 2017


elvisangelaccio added a comment.


  @cullmann After thinking more about it, the URL does change twice (old url -> QUrl(), QUrl() -> new url), so it should be expected to get two urlChanged() signals.
  
  Consider this scenario:
  
  - openUrl(foo)
  - part loads url foo.
  - openUrl(bar)
  - openUrl() calls closeUrl()
  - part fails to load url bar.
  
  In this case we only get one urlChanged() signal since we could not open the new url.

REVISION DETAIL
  https://phabricator.kde.org/D6856

To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop
Cc: cullmann, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170724/d8e05cee/attachment.html>


More information about the Kde-frameworks-devel mailing list