D6877: Add Conan files

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Jul 24 13:40:55 UTC 2017


apol added inline comments.

INLINE COMMENTS

> conanfile.py:3
> +
> +class KarchiveConan(ConanFile):
> +    name = "KArchive"

`KArchiveConan`?

> conanfile.py:5
> +    name = "KArchive"
> +    version = "5.37.0-git"
> +    license = "lgpl2"

Can we re-use the version from the `CMakeLists.txt`?

> conanfile.py:7
> +    license = "lgpl2"
> +    url = "<Package recipe repository url here, for issues about the package>"
> +    settings = "os", "compiler", "build_type", "arch"

Re-use from metainfo.yml?

> conanfile.py:9
> +    settings = "os", "compiler", "build_type", "arch"
> +    options = {"shared": [True, False]}
> +    default_options = "shared=True"

I don't understand what this means :(

> conanfile.py:4
> +
> +class KarchiveTestConan(ConanFile):
> +    settings = "os", "compiler", "build_type", "arch"

`KArchiveTestConan`

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D6877

To: gladhorn
Cc: apol, cfeck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170724/c61ada64/attachment.html>


More information about the Kde-frameworks-devel mailing list