D6772: Fix usage of query_qmake: differ between calls expecting qmake or not
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Jul 18 16:38:02 UTC 2017
kossebau created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
REVISION SUMMARY
when KDE_INSTALL_USE_QT_SYS_PATHS has been explicitely set,
qmake can be considered a required dependency, otherwise the
paths will not be known, which would be unexpected.
Also does the code calling query_qmake, besides the one testing
for the same install prefix, not handle the case of empty strings
being returned and then results in bogus behaviour.
Thus this patch makes code fail hard if query_qmake is expected
to yield a result, but no qmake executable is found.
REPOSITORY
R240 Extra CMake Modules
BRANCH
handlenoqmakefound
REVISION DETAIL
https://phabricator.kde.org/D6772
AFFECTED FILES
kde-modules/KDEInstallDirs.cmake
modules/ECMAddQch.cmake
modules/ECMGeneratePriFile.cmake
modules/ECMQueryQmake.cmake
To: kossebau, #frameworks, ltoscano, rdieter
Cc: #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170718/1b50ec3b/attachment.html>
More information about the Kde-frameworks-devel
mailing list