D6687: Adding support to ipv*.route-metric

[Jan Grulich]

jgrulich added a comment.


  Looks good to me now, it looked to me good even before, but didn't read carefully the documentation. Lamarque, do you see anything else?

INLINE COMMENTS

> ipv4setting.cpp:455
>  
> +    if(routeMetric() >= 0) {
> +        setting.insert(QLatin1String(NMQT_SETTING_IP4_CONFIG_ROUTE_METRIC), routeMetric());

Missing space between if and bracket.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D6687

To: pvillani, jgrulich, lvsouza
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170718/786a1344/attachment.html>