D6727: Destroy all kwayland objects created by registry when it is destroyed
Martin Flöser
noreply at phabricator.kde.org
Sun Jul 16 14:29:23 UTC 2017
graesslin added a comment.
In https://phabricator.kde.org/D6727#125900, @davidedmundson wrote:
> We still need https://phabricator.kde.org/D6571, with my proposed change. That's a special case where we delete the connection before the QPA.
It might be that we don't need it. Also KWin destroys the QPA and maybe that's sufficient - Breeze has it's own ConnectionThread which is not shared with KWin's.
> My added connect means that we get that signal regardless of whether we're in Kwin or not.
>
> What we wouldn't need is the ownership changes you did for Breeze (and would otherwise still need doing in Oxygen/QtCurve )
>
>> May I ask for a small unit test for the new functionality?
>
> For you, a *big* unit test.
Just extend the existing ones - that should do and is hopefully small ;-)
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6727
To: davidedmundson
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170716/cdc21e54/attachment.html>
More information about the Kde-frameworks-devel
mailing list