D6687: Adding support to ipv*.route-metric

[Lamarque Souza]

lvsouza requested changes to this revision.
lvsouza added a comment.
This revision now requires changes to proceed.


  The summary says this patch adds route metric support to IPv4 too, but no IPv4 file is touched by this patch. Have you missed the IPv4 changes?

INLINE COMMENTS

> ipv6setting.cpp:412
>  
> +    if(routeMetric() > 0){
> +        setting.insert(QLatin1String(NMQT_SETTING_IP6_CONFIG_ROUTE_METRIC), routeMetric());

You could have added a comment stating that according to NetworkManager's documentation zero is not a possible value for IPv6's route metric (the value is automatically changed to 1024 when trying to set it to zero).

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D6687

To: pvillani, jgrulich, lvsouza
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170714/05b57d78/attachment.html>