D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event

Elvis Angelaccio noreply at phabricator.kde.org
Thu Jul 13 16:03:09 UTC 2017


elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Commit https://phabricator.kde.org/R241:1e251d2f6a428fc5cc27a766c2a6d7b5e8fb2594 does not work with KUrlNavigator drops because the
  drop event is processed at the KUrlNavigatorButton level. This means
  that passing a KUrlNavigator to KJobWidgets::setWindow() results in a
  wrong position for KIO::drop() menus (both on Wayland and X11).
  
  To fix this issue, the DropJob needs to be associated to the
  KUrlNavigatorButton that received the drop event. This class is
  not exported, so we add a getter to KUrlNavigator that exposes
  the relevant KUrlNavigatorButton as QWidget (which is enough because
  the DropJob just needs to call mapToGlobal() on it).

TEST PLAN
  Use case in https://phabricator.kde.org/D6684

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6685

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h

To: elvisangelaccio, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170713/b7635a1e/attachment.html>


More information about the Kde-frameworks-devel mailing list