D6679: Treat Button/ToolButton labels as plaintext
Fabian Vogt
noreply at phabricator.kde.org
Thu Jul 13 13:07:14 UTC 2017
fvogt created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The label text gets treated as RichText/StyledText, which is required
to display mnemonics underlined. Therefore it is necessary to manually
HTML escape the label text, which unfortunately breaks mnemonics as
escaped HTML contains ampersands.
This commit fixes that by introducing a custom function to stylize
mnemonics in HTML escaped text.
TEST PLAN
Ran a modified knotificationdbustest with "<h1>&&a&ction</h1>" and
"actio&n2" as actions. Result: http://i.imgur.com/xHifDBu.png
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6679
AFFECTED FILES
src/declarativeimports/plasmastyle/ButtonStyle.qml
src/declarativeimports/plasmastyle/ToolButtonStyle.qml
src/declarativeimports/plasmastyle/private/Util.js
To: fvogt, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170713/9b0f331d/attachment.html>
More information about the Kde-frameworks-devel
mailing list