D6624: do not crash qaccessible by causing a resize in a resize event

Harald Sitter noreply at phabricator.kde.org
Tue Jul 11 12:09:55 UTC 2017


sitter added a comment.


  In https://phabricator.kde.org/D6624#124077, @cfeck wrote:
  
  > Reading your description on the referenced QTBUG, does it help to use a compare with previous m_columns in KCharSelectItemModel ::setColumnCount() before doing the emit dance?
  
  
  It probably does. To me, that would seem a bit too close to the cause though. If tomorrow another bit of the resizing calculation starts causing a re-layout it would crash again. That said, I think adding an `if` would be handy either way, what with saving a bunch of cpu cycles.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D6624

To: sitter, gladhorn
Cc: cfeck, anthonyfieroni, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170711/48e08beb/attachment.html>


More information about the Kde-frameworks-devel mailing list