D6554: [Plasma Dialog] Fix flag condition

[David Edmundson]

davidedmundson added a comment.


  Your description doesn't match the code
  
  > This didn't work when other flags,, such as WindowStaysOnTopHint were present.
  
  & Flag is the same as TestFlag()
  
  From what I can tell, you've changed:
  
  if (!tooltipFlag && !notification)
  into if(!   (tooltipFlag && !notification)
  
  which is quite possibly correct and valid, but it doesn't match what you said.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170707/51e4b625/attachment.html>