D6547: Fix build with Qt 5.9.1 and clang

Elvis Angelaccio noreply at phabricator.kde.org
Fri Jul 7 09:37:31 UTC 2017


elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Qt 5.9.1 expands Q_REQUIRED_RESULT to the <https://phabricator.kde.org/w/nodiscard/> attribute (see
  commit d254d8c19 in qtbase). This breaks the build with clang compilers
  because <https://phabricator.kde.org/w/nodiscard/> cannot be used at the end of a function
  declaration:
  
    error: 'nodiscard' attribute cannot be applied to types
  
  For the record, GCC just issues a 'attribute ignored' warning when
  <https://phabricator.kde.org/w/nodiscard/> is used at the end of a declaration.

TEST PLAN
  ki18n now builds with clang + Qt 5.9.1

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6547

AFFECTED FILES
  src/klocalizedstring.h

To: elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170707/6fe47b30/attachment.html>


More information about the Kde-frameworks-devel mailing list