D6537: Fix display of formatDuration with rounding.

David Edmundson noreply at phabricator.kde.org
Thu Jul 6 20:16:39 UTC 2017


davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  When showing the time (1 hour 59.5 minutes) with seconds hidden we
  want to show "2 hours 0 minutes" not "1 hour 60 minutes".
  
  This is fixed by performing the rounding before we split the number of
  miliseconds into component parts, rather than splitting and then
  rounding.
  
  BUG: 360681
  BUG: 382069

TEST PLAN
  Updated unit test

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6537

AFFECTED FILES
  autotests/kformattest.cpp
  src/lib/util/kformatprivate.cpp

To: davidedmundson
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170706/6d87c517/attachment.html>


More information about the Kde-frameworks-devel mailing list