D6390: Add remote runners over DBus

[David Edmundson]

davidedmundson marked 9 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in dbusrunnertest.cpp:88
> Why are you using `QString` and not `QStringLiteral` all over the place?

because it's in a test...

> broulik wrote in dbusrunner.cpp:109
> We cannot have matches with different actions then, right? I don't think we do that in any other runner, so this is fine.

It would be possible to do, we can have RemoteMatch have a list of actionIDs with it.

We'd then have to cache that in the queryMatch, which would be easier if I wasn't already using setData as id gets mangled and could fetch them here.

> broulik wrote in querymatch.h:77
> ` = nullptr`
> 
> Seems an unrelated (and unneccessary?) change to me, though

I have to Q_DECLARE_METATYPE for QSignalSpy.

That means it needs a default constructor.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D6390

To: davidedmundson, #plasma
Cc: broulik, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170706/84932678/attachment.html>