D6473: Crash when replacing new lines with spaces

[John Salatas]

jsalatas created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Fixes bug 381080
  https://bugs.kde.org/show_bug.cgi?id=381080

TEST PLAN
  The problem was that it looked for multiline pattern only in case of a RegExp search. I extended it to also  look for  multiline pattern also in case of EscapeSequence search, which seems to fix the problem.
  
  Notice: I haven't checked but I strongly believe that the isMultiLine() will return false positives in case of EscapeSequence searches. Although this may create a small annoyance to the user (moving the cursor to another line), I believe it is still a better approach than just let it crash. In any case I would appreciate any suggestions on how to handle it in a better way.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D6473

AFFECTED FILES
  src/search/katesearchbar.cpp

To: jsalatas, #ktexteditor
Cc: kwrite-devel, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170702/7ad594c0/attachment.html>