[Differential] [Request, 4 lines] D4361: [Containment] Move contains() check inside NDEBUG

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Jan 31 09:58:12 UTC 2017


broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Since we don't return and only do something when NDEBUG is defined, don't do contains() for no reason.

TEST PLAN
  Not sure how useful this thing even is since the qCDebug inside the define is commented, even..

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4361

AFFECTED FILES
  src/plasma/containment.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170131/79044425/attachment.html>


More information about the Kde-frameworks-devel mailing list