[Differential] [Request, 4 lines] D4348: [Containment Interface] No need for values() as contains() looks up keys
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Jan 30 13:17:15 UTC 2017
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Avoids creating a temporary list for no reason.
Also use value() which is always const compared to operator[]
TEST PLAN
Dropped a file, still got an icon widget
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4348
AFFECTED FILES
src/scriptengines/qml/plasmoid/containmentinterface.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170130/6512a381/attachment.html>
More information about the Kde-frameworks-devel
mailing list