[Differential] [Request, 14 lines] D4335: Fix endianness issues once and for all in Blowfish algorithm
A. Wilcox
noreply at phabricator.kde.org
Sun Jan 29 18:26:19 UTC 2017
awilcox created this revision.
awilcox set the repository for this revision to R311 KWallet.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Attempting to package KWallet 5.29.0 for PowerPC, I ran in to a test failure with the Blowfish algorithm. This led me to bug 362805 <https://bugs.kde.org/show_bug.cgi?id=362805>. I have implemented the suggested fix from comment 17 there, with a small change; it is better to simply include <QtGlobal> than <QtCore/qglobal.h>.
TEST PLAN
- Built on x86_64 computer with patch applied; opened existing wallet.
- Built on PowerPC computer with patch applied; opened existing wallet.
- Created new wallet on x86_64 computer, and opened it on PowerPC computer.
REPOSITORY
R311 KWallet
REVISION DETAIL
https://phabricator.kde.org/D4335
AFFECTED FILES
kwallet-5.29.0/src/runtime/kwalletd/backend/blowfish.cc
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: awilcox
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170129/99b727a0/attachment.html>
More information about the Kde-frameworks-devel
mailing list