Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129892/
-----------------------------------------------------------

(Updated Jan. 29, 2017, 6:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Anthony Fieroni and David Faure.


Changes
-------

Submitted with commit a8d97669f527bcbc4606ae695947fb3bb59d8a92 by Albert Astals Cid to branch master.


Repository: kconfigwidgets


Description
-------

It makes no sense to treat no menubars as all menubars native so just bail early, the app is probably still in construction if there's no menubars but it actually has a showmenubaraction.


Diffs
-----

  src/kstandardaction.cpp 6e5bba7 

Diff: https://git.reviewboard.kde.org/r/129892/diff/


Testing
-------

Dolphin behaves better regarding the show menubar action.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170129/86475850/attachment.html>