Review Request 129842: KAuth: update most of the examples, drop outdated ones
Elvis Angelaccio
elvis.angelaccio at kde.org
Sun Jan 29 17:20:11 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129842/
-----------------------------------------------------------
(Updated Jan. 29, 2017, 5:20 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
-------
Submitted with commit 6cbfcbf2dbb27266ecd36d0592cefd5cb1cc568d by Elvis Angelaccio to branch master.
Repository: kauth
Description
-------
This moves most of the example snippets (which were outdated) into real cmake targets. We use the Doxygen `@snippet` magic to show them in the apidox. This ensures that the example code is always compiled and stays up-to-date.
Some of the snippets are just removed, in particular the section about executing the actions asynchronously, which predates the KJob (ExecuteJob) usage.
Diffs
-----
CMakeLists.txt 58d0f2a5d6c2f442097a27e229a1b8cb3ec35f73
examples/CMakeLists.txt PRE-CREATION
examples/client.cpp PRE-CREATION
examples/helper.cpp PRE-CREATION
metainfo.yaml f709143c00d70c834d6ccde103f575be3771d448
src/kauthactionreply.h 6203df034483c102eb82220cca3dac313a094f41
Diff: https://git.reviewboard.kde.org/r/129842/diff/
Testing
-------
Examples targets build fine.
Ran kapidox locally, code snippets shows up in the documentation of the KAuth namespace.
Thanks,
Elvis Angelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170129/b5d66e72/attachment.html>
More information about the Kde-frameworks-devel
mailing list