[Differential] [Request, 288 lines] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Sun Jan 29 02:35:08 UTC 2017
kossebau created this revision.
kossebau added reviewers: Frameworks, dhaumann.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Calling animatedHide() on a not yet shown KMessageWidget instance was
ignored when the parent
And instant counter-direction updates (like it can happen due to complicated signal
handling on UI updates) resulted in the last calls being ignored,
so an instant hide after a show or an instant show after a hide were
ineffective, resulting in wrong messages or wrongly no messages shown.
TEST PLAN
Works now in WIP KDevelop code,
and new unit tests no longer fail.
REPOSITORY
R236 KWidgetsAddons
BRANCH
fixKMessageWidgetInstantShowHide
REVISION DETAIL
https://phabricator.kde.org/D4329
AFFECTED FILES
autotests/kmessagewidgetautotest.cpp
autotests/kmessagewidgetautotest.h
src/kmessagewidget.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, #frameworks, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170129/277270e2/attachment.html>
More information about the Kde-frameworks-devel
mailing list