Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129892/#review102269
-----------------------------------------------------------



So, wait a minute i just quote you
*This patch attempts to fix it by iterating all the main windows when they are shown and if all the menubars of all mainwindows are native, then hides the show menu bar action (basically erasing it from existence).* from https://git.reviewboard.kde.org/r/129261/
*This has nothing to do with whether you are using Unity or Plasma* from https://git.reviewboard.kde.org/r/129885/
I want an explanation, i never use Unity, i will never use it, but i want know in Unity - Kate, Dolphin etc. on showEvent allMenuBarsNative == true, wasNative == true ?
If so, i'm -1 for this approach

- Anthony Fieroni


On Ян. 27, 2017, 12:19 преди обяд, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129892/
> -----------------------------------------------------------
> 
> (Updated Ян. 27, 2017, 12:19 преди обяд)
> 
> 
> Review request for KDE Frameworks, Anthony Fieroni and David Faure.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> It makes no sense to treat no menubars as all menubars native so just bail early, the app is probably still in construction if there's no menubars but it actually has a showmenubaraction.
> 
> 
> Diffs
> -----
> 
>   src/kstandardaction.cpp 6e5bba7 
> 
> Diff: https://git.reviewboard.kde.org/r/129892/diff/
> 
> 
> Testing
> -------
> 
> Dolphin behaves better regarding the show menubar action.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170127/d9daee54/attachment.html>