Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars
Albert Astals Cid
aacid at kde.org
Thu Jan 26 22:19:14 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129892/
-----------------------------------------------------------
Review request for KDE Frameworks, Anthony Fieroni and David Faure.
Repository: kconfigwidgets
Description
-------
It makes no sense to treat no menubars as all menubars native so just bail early, the app is probably still in construction if there's no menubars but it actually has a showmenubaraction.
Diffs
-----
src/kstandardaction.cpp 6e5bba7
Diff: https://git.reviewboard.kde.org/r/129892/diff/
Testing
-------
Dolphin behaves better regarding the show menubar action.
Thanks,
Albert Astals Cid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170126/c505b36e/attachment.html>
More information about the Kde-frameworks-devel
mailing list