Review Request 129885: [KStandadAction] Correct mebars logic

Anthony Fieroni bvbfan at abv.bg
Wed Jan 25 20:38:14 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129885/
-----------------------------------------------------------

Review request for KDE Frameworks, Albert Astals Cid and David Faure.


Repository: kconfigwidgets


Description
-------

This patch is *ugly* makes side effects on KDE menubars. Start Dolphin -> hide menubar -> restart it -> click control button -> menubar action is checked.
It hide all actions changed between updateAction calls e.g.
updateAction (stores last state of checked and enable)
application changed menu action like it want
updateAction is called on show event -> discard modified states


Diffs
-----

  src/kstandardaction.cpp 6e5bba7 

Diff: https://git.reviewboard.kde.org/r/129885/diff/


Testing
-------

Works correct on KDE, test it on Unity.
Please don't make such a patch, respect application behavior.


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170125/6988a53b/attachment.html>


More information about the Kde-frameworks-devel mailing list