[Differential] [Changed Subscribers] D4227: Don't block when running the post-install command

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> installation.cpp:351
> +        QProcess* p = runPostInstallationCommand(installedFiles.size() == 1 ? installedFiles.first() : targetPath);
> +        connect(p, static_cast<void(QProcess::*)(int)>(&QProcess::finished), this, f);
> +    } else {

I had to look multiple times to find what "f" is, can you make the name a bit more descriptive.

> installation.cpp:592
> +        }
> +        sender()->deleteLater();
> +    });

You could just capture the QProcess* into the lambda

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4227

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir, whiting, mart
Cc: broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170123/3e920740/attachment-0001.html>