Review Request 127223: Don't emit destroyedChanged(true) twice

Albert Astals Cid aacid at kde.org
Fri Jan 20 23:28:54 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127223/#review102121
-----------------------------------------------------------



Doesn't apply anymore.

- Albert Astals Cid


On Feb. 29, 2016, 4:19 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127223/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 4:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> it's set to true when the panel is removed and the notification shown,
> it's wrong to emit it again when the timeout comes to actually delete
> the containment.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/applet_p.cpp f4ecaf45ee7cf753de4b0262a0bb205f68c440d9 
> 
> Diff: https://git.reviewboard.kde.org/r/127223/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170120/c9d86164/attachment.html>


More information about the Kde-frameworks-devel mailing list