Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

[Anthony Fieroni]

> On Jan. 19, 2017, 5:36 p.m., Stefan Brüns wrote:
> > src/extractorcollection.cpp, line 155
> > <https://git.reviewboard.kde.org/r/129720/diff/1/?file=488223#file488223line155>
> >
> >     This is broken:
> >     
> >     if (plugins.isEmpty()) {
> >       ...
> >       for (; it != d->m_extractors.constEnd(); it++) {
> >          if (plugins.contains( some_value )
> >     
> >     The "plugins.contains(...)" is always false.

not always, line 150 appending to list, this guard to protect duplicate extractor


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129720/#review102096
-----------------------------------------------------------


On Dec. 29, 2016, 9:17 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129720/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2016, 9:17 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> startsWith is a weak precondition + guard for duplicate plugin
> 
> 
> Diffs
> -----
> 
>   src/extractorcollection.cpp d0fbbea 
> 
> Diff: https://git.reviewboard.kde.org/r/129720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170119/269aff22/attachment.html>