[Differential] [Requested Changes To] D3826: Detect inotify.

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> FindInotify.cmake:51
> +if(Inotify_INCLUDE_DIRS)
> +  # On Linux there is no library to link against, on the BSDs there is.
> +  # On the BSD's, inotify is implemented through a library, libinotify.

Style: Indent off

> FindInotify.cmake:54
> +    if( CMAKE_SYSTEM_NAME MATCHES "Linux")
> +        set(Inotify_FOUND TRUE)
> +    else()

Set `Inotify_LIBRARIES` & `Inotify_INCLUDE_DIRS` to empty string?

> FindInotify.cmake:76
> +
> +mark_as_advanced(Inotify_FOUND) 

`Inotify_LIBRARIES` & `Inotify_INCLUDE_DIRS` should be marked as advanced instead

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3826

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: adridg, apol, arrowdodger, #buildsystem, #frameworks, tcberner, dfaure, ervin, skelly, kfunk
Cc: kfunk, #freebsd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170116/4690bd73/attachment-0001.html>