Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed

[Elvis Angelaccio]

> On Jan. 15, 2017, 2:32 a.m., Christoph Feck wrote:
> > From what I see, the content widget is not owned by the tool tip widget. What happens if I delete the tool tip widget first, then delete the content widget? Does deleting automatically break the connections to the now non-existing target?

Good point. Actually I just realized that the tooltip does take ownership, so what happens is a double delete :/
However, this is unrelated from this patch (it crashes even if I remove the new connect()).

We could fix this with another patch or maybe we could just warn in the apidox to not delete the content after deleting the tooltip...


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129833/#review102031
-----------------------------------------------------------


On Jan. 14, 2017, 6:54 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129833/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2017, 6:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Otherwise the tooltip will be visible but empty.
> 
> 
> Diffs
> -----
> 
>   autotests/ktooltipwidgettest.h 556d93edd7792736bb7b41761f2d8934395d2f3c 
>   autotests/ktooltipwidgettest.cpp 89124c6b3f16b76a346a8c9c74ff2f9efe0c9e83 
>   src/ktooltipwidget.cpp 979d4f71b5ebf9d0716e12453ecbfc88e48be72d 
> 
> Diff: https://git.reviewboard.kde.org/r/129833/diff/
> 
> 
> Testing
> -------
> 
> The new test case reproduces this issue.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170115/bbb1c9a4/attachment.html>