Review Request 129809: KFontRequester: Find the nearest match for a missing font

[Alexander Volkov]

> On Jan. 12, 2017, 9:08 p.m., Christoph Feck wrote:
> > src/kfontrequester.cpp, line 53
> > <https://git.reviewboard.kde.org/r/129809/diff/1/?file=488949#file488949line53>
> >
> >     Please check if it is possible to use QFont::lastResortFamily() or QFont::lastResortFont().
> 
> Alexander Volkov wrote:
>     As I can see in the Qt 5 code, lastResortFamily() returns hard-coded "helvetica" and lastResortFont() aborts the app by qFatal()
> 
> Christoph Feck wrote:
>     ouch, that's not according to the documentation. Let's hope nobody notices we are hard-coding another font name.

well, lastResortFamily() seems to be a better choice than hardcoded "fixed"


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/#review101970
-----------------------------------------------------------


On Jan. 13, 2017, 12:45 p.m., Alexander Volkov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129809/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2017, 12:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Bugs: 286260
>     https://bugs.kde.org/show_bug.cgi?id=286260
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> If the font is missing, then try to find the nearest font
> family instead of just selecting the first family in the
> list.
> 
> BUG: 286260
> 
> 
> Diffs
> -----
> 
>   src/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 
> 
> Diff: https://git.reviewboard.kde.org/r/129809/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Volkov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170113/9bff7af1/attachment.html>