Review Request 129809: KFontRequester: Find the nearest match for a missing font

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/#review101970
-----------------------------------------------------------




src/kfontrequester.cpp (line 51)
<https://git.reviewboard.kde.org/r/129809/#comment68200>

    Here you are creating a second QFontInfo object.



src/kfontrequester.cpp (line 53)
<https://git.reviewboard.kde.org/r/129809/#comment68201>

    Please check if it is possible to use QFont::lastResortFamily() or QFont::lastResortFont().


- Christoph Feck


On Jan. 12, 2017, 6:57 p.m., Alexander Volkov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129809/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 6:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Bugs: 286260
>     https://bugs.kde.org/show_bug.cgi?id=286260
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> If the font is missing, then try to find the nearest font
> family instead of just selecting the first family in the
> list.
> 
> BUG: 286260
> 
> 
> Diffs
> -----
> 
>   src/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 
> 
> Diff: https://git.reviewboard.kde.org/r/129809/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Volkov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170112/deba189c/attachment.html>