[Differential] [Commented On] D4092: Part Revert "[Units] Make iconSizes property constant"

[Aleix Pol Gonzalez]

apol added a comment.


  In https://phabricator.kde.org/D4092#76633, @davidedmundson wrote:
  
  > In https://phabricator.kde.org/D4092#76611, @apol wrote:
  >
  > > I don't get it. If it changes, why is it constant?
  >
  >
  > The icon sizes change
  >
  > These are exposed in a QQmlPropertyMap
  >  The address of that QQmlPropertyMap is always the same
  
  
  Ah, of course, I read the code wrong.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4092

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, #frameworks
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170112/c72bc276/attachment.html>