[Differential] [Request, 89 lines] D4072: Bug reporter: Allow a URL (not just as an email address) for custom reporting

[Jonathan Marten]

marten created this revision.
marten added a reviewer: Frameworks.
marten set the repository for this revision to R263 KXmlGui.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  The rather old bug https://bugs.kde.org/show_bug.cgi?id=277142, although raised against KDE4 kdelibs, still applies to KDE Frameworks.  The bug reporting address is assumed to be an email address in the "Report Bug" dialogue (KBugReport) and in the "About" dialogue "Author" tab (the "Please report bugs to..." link).
  
  This patch corrects this for the KXmlGui framework.  If submission is not to bugs.kde.org then KAboutApplicationDialog attempts to parse the bug address as a URL;  only if the resulting URL has no scheme is "mailto:" assumed.  This is then presented to the user as the clickable link.
  
  KBugReport currently handles only two cases, either the wizard at bugs.kde.org or an email address.  This is extended to handle a third case, a custom URL.  To distinguish the three cases the d->submitBugWeb boolean is changed to d->bugDestination, a KBugReportPrivate::BugDestination enum.  In the third case, the dialogue is shown in the same way as for bugs.kde.org reporting, but with different wording for the message and button.
  
  The manual test at tests/kbugreporttest.cpp is extended to test this third case.

TEST PLAN
  Checked for correct operation of tests/kbugreporttest for the three cases.
  
  Checked for correct appearance and operation of the "About application" dialogue and "Report Bug" for  KWrite, a standard KDE application reporting to bugs.kde.org.
  
  Checked appearance and operation of those for my own application using a custom bug reporting address, as an email address and as a http: URL.
  
  Checked for correct operation of DrKonqi with a standard bug reporting address.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D4072

AFFECTED FILES
  src/kaboutapplicationdialog.cpp
  src/kbugreport.cpp
  tests/kbugreporttest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170110/15f81116/attachment.html>