[Differential] [Request, 2 lines] D4040: [Icon Item] Round size we want to load a pixmap in

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jan 9 10:43:04 UTC 2017


broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  QML sizes can be fractional. In case we're asked to load a 31.5 px pixmap it would truncate it to 31 and then round down to 22 causing a blurry result. Instead, round the size.

TEST PLAN
  Fixes blurry media controls in task manager for me.
  
  Problem is also that the new aspect-ratio aware IconItem always scales the pixmap up to its size regardless of the pixmap size. In any case this patch still makes sense imho

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D4040

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170109/040d7cf6/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list