Review Request 129694: About dialog: fix scrolling in Authors tab

[Elvis Angelaccio]

> On Jan. 7, 2017, 7:10 p.m., Albert Astals Cid wrote:
> > I don't know what "Scroll is now smooth in the Authors tab of the about dialog."
> > 
> > But if i compare Qt 5.7.1 with this patch and Qt 5.6.1, they are different reacting to the wheel.
> > 
> > "Qt 5.7.1 with this patch" is much more jumpier than  Qt 5.6.1.
> > 
> > So i guess that'd be a -1 from my side.
> 
> Elvis Angelaccio wrote:
>     >"Qt 5.7.1 with this patch" is much more jumpier than  Qt 5.6.1.
>     
>     Right, I didn't notice that at first. Looks like the Qt bug is not really fixed after all?
>     Anyway, what about changing the single step from 3 to 10? 10 is what [knewstuff is also using][1] and feels better for me (tested with Dolphin, which has many authors).
>     
>     [1]: https://phabricator.kde.org/source/knewstuff/browse/master/src/ui/itemsview.cpp;58b0e2435492dffa019b16182cffb3bc7d7e631d$33
> 
> Albert Astals Cid wrote:
>     3 feels perfect for me, do you have by any change a highdpi screen?

Nope. 3 feels a bit slow for me and I guess also for Alexander in the bug report, but ok. 10 would be still an hardcoded value, so what we really need here is a proper fix in upstream QListView...


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129694/#review101851
-----------------------------------------------------------


On Dec. 22, 2016, 4:56 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129694/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 4:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 345434
>     https://bugs.kde.org/show_bug.cgi?id=345434
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> https://bugreports.qt.io/browse/QTBUG-7232 has been fixed in Qt 5.7.0.
> This patch removes the workaround (which causes slow scrolling in the Authors tab) if Qt >= 5.7.
> 
> BUG: 345434
> FIXED-IN: 5.30
> 
> 
> Diffs
> -----
> 
>   src/kaboutapplicationpersonlistview_p.cpp 17b5681a0dfb0657f7e432e5281137ee2ed20e3d 
> 
> Diff: https://git.reviewboard.kde.org/r/129694/diff/
> 
> 
> Testing
> -------
> 
> Scroll is now smooth in the Authors tab of the about dialog.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170108/066124fe/attachment.html>