Review Request 129729: [OS X] : don't risk deleting /Applications (!)

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129729/
-----------------------------------------------------------

(Updated Jan. 8, 2017, 9:12 p.m.)


Status
------

This change has been discarded.


Review request for KDE Software on Mac OS X and KDE Frameworks.


Repository: kservice


Description
-------

I noticed that kbuildsyscoca.cpp may delete `QStandardPaths::writableLocation(QStandardPaths::ApplicationsLocation)`, according to the comments if that location is empty, but in practice no check is made whether that's the case.

And that makes the tool very dangerous on Mac, where the native ApplicationsLocation is something very different.

This patch refuses to remove /Applications, and also checks if `appsDir` is indeed empty.


Diffs
-----

  src/sycoca/kbuildsycoca.cpp 5e63907 

Diff: https://git.reviewboard.kde.org/r/129729/diff/


Testing
-------

Works as intended (though I haven't tried to get it to fail, for some curious reason :))


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170108/103e07df/attachment.html>