Review Request 129641: [GHNS Button] Hide when KIOSK restriction applies
David Faure
faure at kde.org
Sun Jan 8 18:47:16 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129641/#review101891
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Dec. 30, 2016, 9:24 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129641/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2016, 9:24 p.m.)
>
>
> Review request for KDE Frameworks, Dan Leinir Turthra Jensen and Jeremy Whiting.
>
>
> Repository: knewstuff
>
>
> Description
> -------
>
> Hiding the button in the first place is prettier than presenting the user with an error when he or she clicks on it.
>
>
> Diffs
> -----
>
> src/button.cpp 9606171
>
> Diff: https://git.reviewboard.kde.org/r/129641/diff/
>
>
> Testing
> -------
>
> Ported KWin's script KCM to use GHNS Button (D3647) and the button hid itself with
>
> [KDE Action Restrictions]
> ghns=false
>
> Unfortunately, there's no QML equivalent, so we either need to come up with one or fix all the KCMs and Plasma manually :/
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170108/b52cc085/attachment.html>
More information about the Kde-frameworks-devel
mailing list