Review Request 129795: Only use .xml and .theme files for highlighting and themes

Dominik Haumann dhaumann at kde.org
Sun Jan 8 18:04:25 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129795/
-----------------------------------------------------------

(Updated Jan. 8, 2017, 6:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for Kate, KDE Frameworks, Christoph Cullmann, and Volker Krause.


Changes
-------

Submitted with commit 8c39a258d627e7444343e337825aad494154bebf by Dominik Haumann to branch master.


Repository: syntax-highlighting


Description
-------

Currently, the QDirIterator lists *all* files when searching for highlighting files and theme files.
This for instance also includes backups (.xml~) and similar files, which is obviously wrong.

This patch fixes this by searching only for .xml files and .theme files.


Diffs
-----

  src/lib/repository.cpp 13783f8 

Diff: https://git.reviewboard.kde.org/r/129795/diff/


Testing
-------

Compiles, unit tests still run.


Thanks,

Dominik Haumann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170108/f1d9e2ca/attachment.html>


More information about the Kde-frameworks-devel mailing list