[Differential] [Request, 35 lines] D4023: kformat: Make it possible to properly translate relative days of the week

[mpyne (Michael Pyne)]

mpyne created this revision.
mpyne added reviewers: Frameworks, kde-i18n-doc, aspotashev.
mpyne set the repository for this revision to R244 KCoreAddons.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  KFormat::formatRelativeDate <https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html#a6adf12070942eb8e6c9efd862edb8b65> allows one to obtain a human-readable date like "Last Wednesday" or "Next Thursday" for dates within a week of the current date.
  
  The returned string cannot be properly translated in all languages since it's generated using a placeholder of the form "Next %1" -- the word Next (or Last) may itself need to be modified to be correct which can't be done with the current translation system.
  
  The fix is just to return "Next $dayName" directly, based on the day name as appropriate, and allow the translators to translate the entire phrase.
  
  The auto tests are adjusted as well.  They were actually incorrect before this change, since the API documentation for `formatRelativeDate` makes clear that the date format is only applied if the date is *not* within a week of the current date.
  
  See also Bug 335106 <https://bugs.kde.org/show_bug.cgi?id=335106>.

TEST PLAN
  Change builds and installs properly, and all kcoreaddons tests continue to pass (with the `kformattest` autotest revised per this change).

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4023

AFFECTED FILES
  autotests/kformattest.cpp
  src/lib/util/kformatprivate.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mpyne, #frameworks, kde-i18n-doc, aspotashev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170108/df45a529/attachment.html>