Review Request 129517: don't ignore return value, verify it

David Faure faure at kde.org
Sun Jan 8 16:03:38 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129517/#review101872
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On Nov. 21, 2016, 10:06 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129517/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 10:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: syntax-highlighting
> 
> 
> Description
> -------
> 
> if we can't mkdir the output dir all tests will fail on creating the output
> file, but rather implicitly at that
> 
> 
> Diffs
> -----
> 
>   autotests/testhighlighter.cpp f8023817f93bf8f205c788c50cd45c7860982171 
> 
> Diff: https://git.reviewboard.kde.org/r/129517/diff/
> 
> 
> Testing
> -------
> 
> passes still
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170108/dfc58572/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list