[Differential] [Accepted] D4018: Fix mini map for HiDPI settings

dhaumann (Dominik Haumann) noreply at phabricator.kde.org
Sun Jan 8 15:39:11 UTC 2017


dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  In general ok - but sure whether we need qCeil() to round sizes up, but if it looks ok, it's probably fine to commit.

INLINE COMMENTS

> kateviewhelpers.cpp:479
>  
> -    m_pixmap = QPixmap(pixmapLineWidth, pixmapLineCount);
> +    // increase dimensions by ratio
> +    m_pixmap = QPixmap(pixmapLineWidth * m_view->devicePixelRatio(), pixmapLineCount * m_view->devicePixelRatio());

Do we maybe need a qCeil here?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4018

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cullmann, dhaumann, #kate
Cc: kwrite-devel, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170108/4a637390/attachment.html>


More information about the Kde-frameworks-devel mailing list