Review Request 129760: Fixup handling of KFontUtils::adaptFontSize's flags' default value.

[Shaheed Haque]

> On Jan. 5, 2017, 10:56 p.m., Stephen Kelly wrote:
> > I've added the change to the unit test. It already passes, so it's not clear to me what else is needed from this review request.

What version of SIP compiler and C++ compiler are you using? I'm on:

$ sip -V
4.18.1
$ g++ --version
g++ (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

In any case, unless the change breaks thing for you, I would prefer to merge the complete change as it is definitely needed here.


- Shaheed


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129760/#review101827
-----------------------------------------------------------


On Jan. 3, 2017, 12:47 p.m., Shaheed Haque wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129760/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2017, 12:47 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> -------
> 
> This depends on a fix in extra-cmake-module to actually emit the
> default value for the flags parameter.
> 
> 
> Diffs
> -----
> 
>   autotests/pythontest.py c93e75397f87ba4a84f834dd248d671614ac89dd 
>   cmake/rules_PyKF5.py PRE-CREATION 
>   src/CMakeLists.txt 63e7598d13fa1c4d9d67e2f99edcc13e0269920e 
> 
> Diff: https://git.reviewboard.kde.org/r/129760/diff/
> 
> 
> Testing
> -------
> 
> Without this change, once the code the depends-on review is committed, kguiaddons will fail to compile as follows:
> 
> In file included from /home/.../PyKF5/KGuiAddons/unifiedKGuiAddons.cpp:1:0:
> /home/.../PyKF5/KGuiAddons/sipKGuiAddonsKFontUtils.cpp: In function ‘PyObject* meth_KFontUtils_adaptFontSize(PyObject*, PyObject*)’:
> /home/...d/PyKF5/KGuiAddons/sipKGuiAddonsKFontUtils.cpp:30:50: error: ‘NoFlags’ was not declared in this scope
>          KFontUtils::AdaptFontSizeOptions a6def = NoFlags;
> 
> With the change, it compiles and the tests run:
> 
> $ ctest
> Test project /home/srhaque/kdebuild/kguiaddons
>     Start 1: appstreamtest
> 1/6 Test #1: appstreamtest ....................   Passed    0.02 sec
>     Start 2: Py3Test
> 2/6 Test #2: Py3Test ..........................   Passed    0.13 sec
>     Start 3: Py2Test
> 3/6 Test #3: Py2Test ..........................   Passed    0.11 sec
>     Start 4: kwordwraptest
> 4/6 Test #4: kwordwraptest ....................   Passed    0.16 sec
>     Start 5: kcolorutilstest
> 5/6 Test #5: kcolorutilstest ..................   Passed    0.53 sec
>     Start 6: kiconutilstest
> 6/6 Test #6: kiconutilstest ...................   Passed    0.08 sec
> 
> 100% tests passed, 0 tests failed out of 6
> 
> Total Test time (real) =   1.03 sec
> 
> 
> Thanks,
> 
> Shaheed Haque
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170105/e50c90ae/attachment.html>