[Differential] [Accepted] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

[kfunk (Kevin Funk)]

kfunk accepted this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision is now accepted and ready to land.


  Rest LGTM, but let's wait for another review

INLINE COMMENTS

> kdynamicjobtrackernowidgetstest.cpp:34
> +public:
> +    virtual void start() { QTimer::singleShot(testJobRunningTime, this, &TestJob::doEmit); }
> +

`Q_DECL_OVERRIDE`

> kdynamicjobtracker.cpp:99
> +        } else {
> +            trackers.widgetTracker = 0;
>          }

Here & below: Use `nullptr`?

REPOSITORY
  R241 KIO

BRANCH
  fixKDynamicJobTracker

REVISION DETAIL
  https://phabricator.kde.org/D3977

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, kfunk
Cc: kfunk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170105/db619a00/attachment.html>