Review Request 129770: Return stringlist types in KPluginMetaData::value

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129770/
-----------------------------------------------------------

(Updated Jan. 5, 2017, 1:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 2ee9633a244a44d5b717fd9b00ec3e6e2fb236fa by David Edmundson to branch master.


Repository: kcoreaddons


Description
-------

Plasma code is littered with
KPluginMetaData::value("someStringList").contains("blah")

This used to accidentally work fine because we would be converting
.desktop files and have no concept of what KPluginMetaData entry should
have been a stringlist or a string.

Since 49bc26a135bf92bcddecabfdd4f3f71f65540104 we now correctly work out
the service type of a .desktop file, and so when we parse it, entries
that should have been lists are now considered a QJsonValue of type
Array rather than String, meaning KPluginMetaData::value returns nothing
instead of the original comma separated list in the .desktop file.

Even though we should fix all Plasma instances to use the correct
KPluginMetaData method for the data they're fetching, we can't afford
to have a behavioural change that will cause huge breakages.


Diffs
-----

  src/lib/plugin/kpluginmetadata.cpp 453d243dd3c9287b9637eecd1f4b9840eea09838 

Diff: https://git.reviewboard.kde.org/r/129770/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170105/55c9544a/attachment-0001.html>