Review Request 129771: Handle booleans in KPluginMetaData::value

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129771/
-----------------------------------------------------------

(Updated Jan. 4, 2017, 3:54 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
-------

(same as previous commit but to address booleans, which causes problem seen here: https://phabricator.kde.org/D3959)


This used to accidentally work fine because we would be converting
.desktop files and have no concept of what KPluginMetaData entry should
have been a boolean or a string.

Since 49bc26a135bf92bcddecabfdd4f3f71f65540104 we now correctly work out
the service type of a .desktop file, and so when we parse it, entries
that should have been lists are now considered a QJsonValue of type
Boolean rather than String, meaning KPluginMetaData::value returns
nothing instead of the original true/false value in the .desktop file.

Even though we should fix all Plasma isntances to use the correct
KPluginMetaData method for the data they're fetching, we can't afford
old installs to break.


Diffs (updated)
-----

  src/lib/plugin/kpluginmetadata.cpp 453d243dd3c9287b9637eecd1f4b9840eea09838 

Diff: https://git.reviewboard.kde.org/r/129771/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170104/6b09481b/attachment-0001.html>