Review Request 129734: KSycoca unittest: reduce the amount of waiting, if Qt >= 5.8 is used.
David Faure
faure at kde.org
Tue Jan 3 11:37:58 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129734/
-----------------------------------------------------------
(Updated Jan. 3, 2017, 11:37 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Albert Astals Cid, Patrick Spendrin, and Hannah von Reth.
Changes
-------
Submitted with commit 43127546b6b0ff52ae098336114e2febe13e3a5e by David Faure to branch master.
Repository: kservice
Description
-------
lastModified() finally returns milliseconds (qtbase commit 494ced1), which
means we don't need to wait a whole second just to detect that a file was
modified.
Not sure about Windows though...
Diffs
-----
autotests/ksycocatest.cpp 4564ee6750a80a109492c197c83944e129dcabac
Diff: https://git.reviewboard.kde.org/r/129734/diff/
Testing
-------
ksycocatest runs much faster now (700 ms instead of 7 s), and still passes
Thanks,
David Faure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170103/24910597/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list